Context menu to swap modules for different variation #346
Conversation
Non functional so far.
Functional, but not handling multiple selections well
Ensure the variations menu only shows when you've got a matching set of items selected.
|
By the way - only tested on Windows, Can test on Linux tomorrow, have no access to a Mac. |
|
Seems to work fine, I like it a lot. The context menu can really increase the speed you can work with pyfa. Btw you still have a "print" in https://github.com/Will-W/Pyfa/blob/master/gui/builtinContextMenus/metaSwap.py#L59 |
|
Ewwwww. That was careless. Removed. |
|
There is an issue on Linux (as I was expecting from looking at the ammo selection code). |
|
Hi, Also, I can test in OS X once you submit linux fix |
|
I only did a quick test to confirm, but in Linux the click event in the sub menu never gets handled. I think on Linux you have to register with the specific submenu but on msw you need to register with the root menu. That's what the ammo switcher code appeared to be doing, and on Linux clicking a module in a submenu doesn't do anything. Can look at tonight. |
|
Have submitted a Linux fix and now tested on Linux and Windows: it looks good. If you could test it on a Mac, @blitzmann, that would be great. |
|
Eh, my os x python is all fucked. I'll go ahead and merge this now and test with OS X once I can get it reinstalled correctly. But since OS X and Linux share a lot in common, I'm sure it'll work |
Context menu to swap modules for different variation
In the true spirit of open source - if you want a feature write it yourself.
This PR adds a right-click context menu (for modules) that brings up a list of meta-variations for the selected item(s). Selecting an item changes those modules to the selected meta-variation.
If multiple items are selected, menu only shows up if the variation list would be the same.
Saves a lot of clicking to meta-up or down a module to fit within skills or power budget etc.
I had a good look at the existing code, but I'm sure there are some style or architectural things you'll want me to fix.
(edit by blitzmann) Screenshot of how it looks: